Stefan Hajnoczi <stefanha@xxxxxxxxxx> writes: > Cole Robinson made some more suggestions: > > * Use %set_build_flags before ./configure to get the default compiler > flags. > > * Use '%license COPYING' instead of %doc. > > * Do not ship the static library. This is distro policy and Fedora > would ship a separate -static package if static libraries are > desired. > > * Source: should be the URL to the sources. URL: should be the URL of > the website or git repo. > > * The devel package needs > Requires: %{name}%{?_isa} = %{version}-%{release} > > Signed-off-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx> LGTM Acked-by: Jeff Moyer <jmoyer@xxxxxxxxxx>