Re: [PATCH 04/11] blk-mq: Facilitate a shared sbitmap per tagset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/3/19 6:54 AM, John Garry wrote:
@@ -483,8 +483,8 @@ static int hctx_tags_bitmap_show(void *data, struct seq_file *m)
      res = mutex_lock_interruptible(&q->sysfs_lock);
      if (res)
          goto out;
-    if (hctx->tags)
-        sbitmap_bitmap_show(&hctx->tags->bitmap_tags.sb, m);
+    if (hctx->tags) /* We should just iterate the relevant bits for this hctx FIXME */

Bart's solution to this problem seemed ok, if he doesn't mind us borrowing his idea:

https://lore.kernel.org/linux-block/5183ab13-0c81-95f0-95ba-40318569c6c6@xxxxxxxxxx/T/#m24394fe70b1ea79a154dfd9620f5e553c3e7e7da See hctx_tags_bitmap_show().

Hi John,

Sure, borrowing that code is fine with me.

Bart.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux