Re: [PATCH v2 2/2] block/xen-blkback: allow module to be cleanly unloaded

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 29.11.19 16:07, Roger Pau Monné wrote:
On Fri, Nov 29, 2019 at 03:02:37PM +0000, Durrant, Paul wrote:
-----Original Message-----
From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Sent: 29 November 2019 15:00
To: Durrant, Paul <pdurrant@xxxxxxxxxx>
Cc: linux-block@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; xen-
devel@xxxxxxxxxxxxxxxxxxxx; Konrad Rzeszutek Wilk
<konrad.wilk@xxxxxxxxxx>; Jens Axboe <axboe@xxxxxxxxx>
Subject: Re: [PATCH v2 2/2] block/xen-blkback: allow module to be cleanly
unloaded

On Fri, Nov 29, 2019 at 01:43:06PM +0000, Paul Durrant wrote:
Add a module_exit() to perform the necessary clean-up.

Signed-off-by: Paul Durrant <pdurrant@xxxxxxxxxx>

LGTM:

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>


Thanks.

AFAICT we should make sure this is not committed before patch 1, or
else you could unload a blkback module that's still in use?


Yes, that's correct.

Given this is a very small change, and not really block related I
think it would be better for both patches to be committed from the Xen
tree, if Jens, Juergen and Boris agree.

I'm fine with that.

And:

Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux