On 11/27/19, 2:09 PM, "Keith Busch" <kbusch@xxxxxxxxxx> wrote:
>> It wasn't my intention to turn NVME_SC_CMD_INTERRUPTED into non-path related error.
>> The goal was to make the command retry after CDR on the same controller. So why
>> does this patch change the meaning of BLK_STS_RESOURCE?
> What I meant by a "non-path error" is that those types of errors for
> nvme go through the "normal" requeuing that checks CRD. The failover
> requeuing does not check CRD. But thinking again, I don't see why the
> failover side can't also be CRD aware.
Yes, the failover side can be CRD aware, but I don't see the point in failing
over to a different path when CRD is set. As you said, this isn't a pathing
error.
We can argue about whether the command is retried on the current controller
or a different controller, but CRD must be observed before the command is retried.
Agreed?
/John
