On Mon, Nov 25, 2019 at 12:49:51PM -0800, Bart Van Assche wrote: > On 11/25/19 12:13 PM, Omar Sandoval wrote: > > On Fri, Nov 15, 2019 at 09:07:11AM -0800, Bart Van Assche wrote: > > > Recently support has been added in the SRP initiator and target drivers > > > for the SoftiWARP driver. Add a test for SRP over SoftiWARP. > > > > > > Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx> > > > --- > > > tests/srp/015 | 42 ++++++++++++++++++++++++++++++++++++++++++ > > > tests/srp/015.out | 2 ++ > > > 2 files changed, 44 insertions(+) > > > create mode 100755 tests/srp/015 > > > create mode 100644 tests/srp/015.out > > > > Hi, Bart, > > > > I'm getting: > > > > srp/015 (File I/O on top of multipath concurrently with logout and login (mq) using the SoftiWARP (siw) driver) [failed] > > runtime 1.076s ... 1.026s > > --- tests/srp/015.out 2019-11-25 12:07:06.749425714 -0800 > > +++ /home/vmuser/repos/blktests/results/nodev/srp/015.out.bad 2019-11-25 12:12:07.634062201 -0800 > > @@ -1,2 +1 @@ > > -Configured SRP target driver > > -Passed > > +mkdir: cannot create directory ‘0x52540012345600000000000000000000’: Invalid argument > > > > This is on v5.4-rc8 with CONFIG_RDMA_SIW=m. Do you know what is wrong > > here? > > Hi Omar, > > I should have mentioned that the SRP iWARP support patches have been > accepted in the RDMA tree but that these are not yet in Linus' tree. The SRP > iWARP patches should be merged in Linus' tree during the current merge > window. If you would like to test these patches before Linus merges the RDMA > pull request, please have a look at https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/log/?h=for-next&ofs=1000 Okay, I figured I was missing something. Can we detect this in requires() so that it doesn't fail on old kernels?