Re: [PATCH 1/1] scsi core: limit overhead of device_busy counter for SSDs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2019-11-19 at 12:07 -0800, Sumanesh Samanta wrote:
>  
> +#define MAX_PER_CPU_COUNTER_ABSOLUTE_VAL (0xFFFFFFFFFFF)
> +#define PER_CPU_COUNTER_OK_VAL (MAX_PER_CPU_COUNTER_ABSOLUTE_VAL>>16)
> +#define USE_DEVICE_BUSY(sdev)	(!(sdev)->host->hostt->use_per_cpu_device_busy \
> +				|| !blk_queue_nonrot((sdev)->request_queue))
> +
> +

I think this macro, which looks at a couple of different flags, one of
which is keyed off a property of the device, rather than the driver,
needs to be further refined.  Also, QUEUE_FLAG_NONROT can be changed by
sysfs, this might cause problems later.

-Ewan





[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux