On Tue, Nov 12, 2019 at 11:09 AM Evan Green <evgreen@xxxxxxxxxxxx> wrote: > > On Tue, Nov 12, 2019 at 12:32 AM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > > > On Mon, Nov 11, 2019 at 10:50:29AM -0800, Evan Green wrote: > > > - if (cmd->ret < 0) > > > + if (cmd->ret == -EOPNOTSUPP) > > > + ret = BLK_STS_NOTSUPP; > > > + else if (cmd->ret < 0) > > > ret = BLK_STS_IOERR; > > > > This really should use errno_to_blk_status. Same for the other hunk. > > Seems reasonable, I can switch to that. Oh wait, the other hunk doesn't deal with blk_status_t at all. Before, it just translated any errno into -EIO. Now, it translates almost any errno to -EIO (the almost being EOPNOTSUPP). So I'll change just the first hunk you pointed out. -Evan
