On 11/11/2019 04:01 PM, Damien Le Moal wrote: > On 2019/11/12 6:18, Chaitanya Kulkarni wrote: >> >This patch exports blk_should_abort() function to avoid dulicate code. > s/dulicate/duplicate > > And why export this symbol ? It is not used in kernel modules so I do > not see the need for it. Yes we don't have any user for this function outside of block layer yet. I'll remove this in next version. > > In any case, the export should be EXPORT_SYMBOL_GPL(). blk-lib.c has EXPORT_SYMBOL() so I kept the same pattern. I'll update this in the next version. >