On Mon 04-11-19 15:48:41, Christoph Hellwig wrote: > On Mon, Nov 04, 2019 at 09:08:47AM +0100, Jan Kara wrote: > > Thanks Jens! I'll look into refactoring the size change / revalidation code > > so that it's easier to understand what's going on... > > I actualy have a series for this. I've started rebasing it on top > of you work and will need to do some testing. My current WIP is here: > > http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/partition-cleanup Cool. Thanks for that! Skimming over the series it looks good to me. The only remaining thing I wanted to look into is bdev->bd_invalidated handling. Because the only thing it actually indicates in practice is that DISK_EVENT_MEDIA_CHANGE was set in check_disk_change(). All the other call chains end up clearing bdev->bd_invalidated before it has any effect. And that just looks very cryptic to me... So my plan was to at least move the setting of bdev->bd_invalidated to check_disk_change() and rename it to something saner if I cannot come up with anything better for propagating the information from check_disk_change() to __blkdev_get(). Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
