On Thu, Oct 31, 2019 at 02:57:51PM +0000, David Howells wrote: > Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > > > It's shorter and more obvious to just write > > > > pipe->head = head; > > > > than it is to write > > > > pipe_commit_write(pipe, head); > > But easier to find the latter. But whatever. May I suggest that you use a name that's easier to grep for? $ git grep -cw p_tail drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c:9 $ git grep -cw p_head drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c:3
