On 10/28/19 12:54 AM, Damien Le Moal wrote:
> Isn't the trace point under submit_bio() in
> generic_make_request_checks() ? So removing the function is not a
> problem for tracing as far as I can tell. Am I missing something ?
Yes you are right, I completely missed that.
Sorry I've created confusion with block_dump and tracepoint.
Block trace code is fine.
The block_dump code under the submit_bio() is only dumps the bios with
the data:-
1171 if (unlikely(block_dump)) {
1172 char b[BDEVNAME_SIZE];
1173 printk(KERN_DEBUG "%s(%d): %s block %Lu on
%s (%u sectors)\n",
1174 current->comm, task_pid_nr(current),
1175 op_is_write(bio_op(bio)) ? "WRITE"
: "READ",
1176 (unsigned long
long)bio->bi_iter.bi_sector,
1177 bio_devname(bio, b), count);
1178 }
I've posted patch-series [1] in the past to move that code out but it
didn't go anywhere in anticipation of more data less requests.
Since it is taking longer to have blktrace extensions RFC to move
forward and [1] didn't go anywhere I wanted to use block_dump
parameter in the blk-zoned.c (not an ideal situation) so that we can
have atleast minimal debug support for the new REQ_OP_ZONE_XXX
operations until we get block trace extensions in the kernel.
Nonetheless, I'll just a send a patch on the top of this which will
make discussion much easier.
[1] :-
https://lore.kernel.org/linux-block/DM6PR04MB57546ECC4CFDDB5535E3382586FB0@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/T/
