Re: [PATCH 1/2 v2] nvme: Cleanup and rename nvme_block_nr()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Damien Le Moal <damien.lemoal@xxxxxxx>
Subject: Re: [PATCH 1/2 v2] nvme: Cleanup and rename nvme_block_nr()
From: Christoph Hellwig <hch@xxxxxx>
Date: Mon, 21 Oct 2019 05:44:14 +0200
Cc: linux-nvme@xxxxxxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>, Keith Busch <kbusch@xxxxxxxxxx>, Sagi Grimberg <sagi@xxxxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, Jens Axboe <axboe@xxxxxxxxx>
In-reply-to: <20191021034004.11063-2-damien.lemoal@wdc.com>
References: <20191021034004.11063-1-damien.lemoal@wdc.com> <20191021034004.11063-2-damien.lemoal@wdc.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Mon, Oct 21, 2019 at 12:40:03PM +0900, Damien Le Moal wrote:
> Rename nvme_block_nr() to nvme_sect_to_lba() and use SECTOR_SHIFT
> instead of its hard coded value 9. Also add a comment to decribe this
> helper.
> 
> Signed-off-by: Damien Le Moal <damien.lemoal@xxxxxxx>

Looks fine,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Follow-Ups:
- Re: [PATCH 1/2 v2] nvme: Cleanup and rename nvme_block_nr()
  - From: Christoph Hellwig

References:
- [PATCH 0/2 v2] Small cleanups
  - From: Damien Le Moal
- [PATCH 1/2 v2] nvme: Cleanup and rename nvme_block_nr()
  - From: Damien Le Moal

Prev by Date: [PATCH 2/2 v2] nvme: Introduce nvme_lba_to_sect()
Next by Date: Re: [PATCH 1/2 v2] nvme: Cleanup and rename nvme_block_nr()
Previous by thread: [PATCH 1/2 v2] nvme: Cleanup and rename nvme_block_nr()
Next by thread: Re: [PATCH 1/2 v2] nvme: Cleanup and rename nvme_block_nr()
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]

Powered by Linux