Re: [PATCH] rq-qos: get rid of redundant wbt_update_limits()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/17/19 8:04 PM, Yufen Yu wrote:
> We have updated limits after calling wbt_set_min_lat(). No need to
> update again.
> 
> Signed-off-by: Yufen Yu <yuyufen@xxxxxxxxxx>
> ---
>  block/blk-sysfs.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
> index 9bfa3ea4ed63..62d79916e429 100644
> --- a/block/blk-sysfs.c
> +++ b/block/blk-sysfs.c
> @@ -482,7 +482,6 @@ static ssize_t queue_wb_lat_store(struct request_queue *q, const char *page,
>  	blk_mq_quiesce_queue(q);
>  
>  	wbt_set_min_lat(q, val);
> -	wbt_update_limits(q);
>  
>  	blk_mq_unquiesce_queue(q);
>  	blk_mq_unfreeze_queue(q);
> 


Looks good to me.
Reviewed-by: Bob Liu <bob.liu@xxxxxxxxxx>




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux