On Fri, Sep 20, 2019 at 5:42 PM Bart Van Assche <bvanassche@xxxxxxx> wrote:
>
> On 9/20/19 12:36 AM, Danil Kipnis wrote:
> > On Wed, Sep 18, 2019 at 7:41 PM Bart Van Assche <bvanassche@xxxxxxx> wrote:
> >> On 6/20/19 8:03 AM, Jack Wang wrote:
> >>> +static int process_msg_sess_info(struct ibtrs_srv *ibtrs,
> >>> + struct ibnbd_srv_session *srv_sess,
> >>> + const void *msg, size_t len,
> >>> + void *data, size_t datalen)
> >>> +{
> >>> + const struct ibnbd_msg_sess_info *sess_info_msg = msg;
> >>> + struct ibnbd_msg_sess_info_rsp *rsp = data;
> >>> +
> >>> + srv_sess->ver = min_t(u8, sess_info_msg->ver, IBNBD_PROTO_VER_MAJOR);
> >>> + pr_debug("Session %s using protocol version %d (client version: %d,"
> >>> + " server version: %d)\n", srv_sess->sessname,
> >>> + srv_sess->ver, sess_info_msg->ver, IBNBD_PROTO_VER_MAJOR);
> >>
> >> Has this patch been verified with checkpatch? I think checkpatch
> >> recommends not to split literal strings.
> >
> > Yes it does complain about our splitted strings. But it's either
> > splitted string or line over 80 chars or "Avoid line continuations in
> > quoted strings" if we use backslash on previous line. I don't know how
> > to avoid all three of them.
>
> Checkpatch shouldn't complain about constant strings that exceed 80
> columns. If it complains about such strings then that's a checkpatch bug.
It doesn't in deed... Will concat those splitted quoted string, thank you.
