Re: [PATCH v5 2/2] block: centralize PI remapping logic to the block layer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jens Axboe <axboe@xxxxxxxxx>
Subject: Re: [PATCH v5 2/2] block: centralize PI remapping logic to the block layer
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Fri, 13 Sep 2019 18:31:21 -0400
Cc: Max Gurtovoy <maxg@xxxxxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, martin.petersen@xxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, keith.busch@xxxxxxxxx, hch@xxxxxx, sagi@xxxxxxxxxxx, shlomin@xxxxxxxxxxxx, israelr@xxxxxxxxxxxx
In-reply-to: <380932df-2119-ad86-8bb2-3eccb005c949@kernel.dk> (Jens Axboe's message of "Wed, 11 Sep 2019 16:01:11 -0600")
Organization: Oracle Corporation
References: <1568215397-15496-1-git-send-email-maxg@mellanox.com> <1568215397-15496-2-git-send-email-maxg@mellanox.com> <380932df-2119-ad86-8bb2-3eccb005c949@kernel.dk>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux)

Jens,

> While I like the idea of centralizing stuff like this, I'm also not
> happy with adding checks like this to the fast path.

Yeah, but at least it's just checking a request queue flag.

-- 
Martin K. Petersen	Oracle Linux Engineering

References:
- [PATCH v5 1/2] block: use symbolic constants for t10_pi type
  - From: Max Gurtovoy
- [PATCH v5 2/2] block: centralize PI remapping logic to the block layer
  - From: Max Gurtovoy
- Re: [PATCH v5 2/2] block: centralize PI remapping logic to the block layer
  - From: Jens Axboe

Prev by Date: [RFC PATCH 1/2] sched/wait: Add wait_threshold
Next by Date: Re: [PATCH v2 1/4] null_blk: do not fail the module load with zero devices
Previous by thread: Re: [PATCH v5 2/2] block: centralize PI remapping logic to the block layer
Next by thread: Re: [PATCH v5 2/2] block: centralize PI remapping logic to the block layer
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]