On 9/13/19 1:22 PM, André Almeida wrote: > On 9/13/19 4:03 PM, Jens Axboe wrote: >> On Sep 13, 2019, at 11:58 AM, André Almeida <andrealmeid@xxxxxxxxxxxxx> wrote: >>> >>> Hello, >>> >>> This patch series address feedback for a previous patch series sent by >>> me "docs: block: null_blk: enhance document style"[1]. >>> >>> First patch removes a restriction that prevents null_blk to load with >>> (nr_devices == 0). This restriction breaks applications, so it's a bug. I >>> have tested it running the kernel with `null_blk.nr_devices=0`. >>> >>> In the previous series I have changed the type of var nr_devices, but I >>> forgot to change the type at module_param(). The second patch fix that. >>> >>> The third patch uses a cleaver approach to make log messages consistent >>> using pr_fmt and the last one add a note on how to do that at the >>> coding style documentation. >> >> Please add Fixes tags to your patches. >> > > I've added to [PATCH 1/4], should I add to all 4 patches? The ones where it's pertinent, yes, always. Both 1-2 fix issues with the previous patches. -- Jens Axboe
