The nvme_setup_rw is fine, but nvme_init_integrity gets values from
the controller id structure so I think it will be better to stick with
the enums that are referenced in the spec (even if they happen to match
the block layer values).
These values aren't really block layer values, but from the SCSI spec,
which NVMe references. So I think this is fine, but if it is a little
confusion we'll have to add a comment.
Yes, at least for patch #2 where we set the disk->protection_type we
need to explain that the dps match t10 in the type definitions.
