On 9/5/2019 11:52 PM, Sagi Grimberg wrote:
Use block layer definition instead of re-defining it with the same
values.
The nvme_setup_rw is fine, but nvme_init_integrity gets values from
the controller id structure so I think it will be better to stick with
the enums that are referenced in the spec (even if they happen to match
the block layer values).
according to the spec:
"NVM Express supports the same end-to-end protection types as DIF. The
type of end-to-end data protection (Type 1, Type 2, or Type 3) is
selected when a namespace is formatted and is reported in the Identify
Namespace data structure."
This is exactly what this patch does.