On 2019/09/04 21:57, Jens Axboe wrote: > On 9/4/19 3:02 AM, Damien Le Moal wrote: >> On 2019/09/04 17:56, Johannes Thumshirn wrote: >>> On 04/09/2019 10:42, Damien Le Moal wrote: >>>> @@ -734,6 +741,7 @@ static void __device_add_disk(struct device *parent, struct gendisk *disk, >>>> exact_match, exact_lock, disk); >>>> } >>>> register_disk(parent, disk, groups); >>>> + >>>> if (register_queue) >>>> blk_register_queue(disk); >>> >>> That hunk looks unrelated, but anyways: >>> Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx> >> >> Oops. Yes, did not delete the blank line when I moved elevator_init_mq() call. >> Jens, should I resend a v4 to fix this ? > > Series looks good to me, I'll just delete this one hunk, not a big deal. > Jens, Thanks. But Ming's comment needed to be addressed, which I did in the V4 I just sent out. I removed the white line chunk too. Best regards. -- Damien Le Moal Western Digital Research