> Il giorno 14 giu 2019, alle ore 23:05, Paolo Valente <paolo.valente@xxxxxxxxxx> ha scritto: > > > >> Il giorno 14 giu 2019, alle ore 22:22, Tejun Heo <tj@xxxxxxxxxx> ha scritto: >> >> Hello, >> >> On Thu, Jun 13, 2019 at 08:10:38AM +0200, Paolo Valente wrote: >>> BFQ does not implement weight_device, but we are not talking about >>> weight_device here. More precisely, *nothing* implements weight_device >>> any longer in cgroups-v1, so the documentation is wrong altogether. >> >> I can't see how renaming an interface file which has different >> behaviors on the same input to the same name is something acceptable. >> Imagine how confusing that'd be to userspace. If you want to rename >> the control knob to io.weight, please implement full semantics for >> both cgroup1 and cgroup2. >> > > I want to, and I've tried to make it easier for you to point me to > what is missing exactly. Once again, the only missing piece I see are > per-device weights. > >> I just posted a separate io.weight implementation for cgroup2 but it's >> easy to provide a way to override the interface files when bfq gets >> selected, so let me know when you have a working implementation of the >> interface. >> > > Ok, thanks. I'll ping you when also per-device weights are available > in BFQ's interface. > Hi Tejun, have you seen the patch introducing per-device weights [1]? [1] https://lkml.org/lkml/2019/8/5/83 Thanks, Paolo > Thanks, > Paolo > >> Thanks. >> >> -- >> tejun >
