> On 22 Jul 2019, at 06.31, Minwoo Im <minwoo.im@xxxxxxxxxxx> wrote:
>
>>> @@ -1111,27 +1112,27 @@ static int nvm_init(struct nvm_dev *dev)
>>> int ret = -EINVAL;
>>>
>>> if (dev->ops->identity(dev)) {
>>> - pr_err("nvm: device could not be identified\n");
>>> + pr_err("device could not be identified\n");
>>> goto err;
>>> }
>>>
>>> - pr_debug("nvm: ver:%u.%u nvm_vendor:%x\n",
>>> + pr_debug("ver:%u.%u nvm_vendor:%x\n",
>>> geo->major_ver_id, geo->minor_ver_id,
>>> geo->vmnt);
>> The above last 2 lines can be squashed and pr_debug call can be made in
>> 2 lines since you have removed the "nvm:" which shortens the first line.
>
> Yeah Okay. Will prepare V2 with this and also s/previx/prefix in the
> title.
>
> Thanks for the review.
>
> Minwoo Im
Besides Chaitanya’s comments, looks good. You can add my review on V2.
Reviewed-by: Javier González <javier@xxxxxxxxxxx>
Attachment:
signature.asc
Description: Message signed with OpenPGP
