Ops, my fault of course. I submitted the patch I made on top of the dev version of bfq. Preparing a V2. Sorry. > Il giorno 15 lug 2019, alle ore 12:49, Holger Hoffstätte <holger@xxxxxxxxxxxxxxxxxxxxxx> ha scritto: > > On 7/15/19 12:18 PM, Paolo Valente wrote: >> Didn't I simply move it forward in that commit? >>> Il giorno 15 lug 2019, alle ore 12:16, Holger Hoffstätte <holger@xxxxxxxxxxxxxxxxxxxxxx> ha scritto: >>> Paolo, >>> >>> The function idling_needed_for_service_guarantees() was just removed in 5.3-commit >>> 3726112ec731 ("block, bfq: re-schedule empty queues if they deserve I/O plugging"). > > Argh, sorry - yes you did, it failed to apply because the asymmetric_scenario > variable was already gone. Fixing the patch to just return the expression so that > it matches 3726112ec731 worked. > > All good! > Holger