Thank you for pointing out. I haven't had time to pay attention to the new features of sqe links. When I was debugging another stuck problem, I found that there was no free the reference count, so I sent the patch about this. Anyway, if necessary, I will resend the patch again, with your rewritten comments. > 在 2019年7月10日，21:57，Jens Axboe <axboe@xxxxxxxxx> 写道： > > On 7/10/19 2:35 AM, Jackie Liu wrote: >> when io_req_defer alloc memory failed, it will be return -EAGAIN. >> But io_submit_sqe cannot be returned immediately because the reference >> count for req is still hold. we should be clean it. > > Looks like this actually got fixed in my for-5.3/io_uring branch which > I haven't pushed out yet. Once that's in, I'd suggest we send yours to > stable separately. Probably change the wording to: > > When io_req_defer alloc memory fails, it will be -EAGAIN. But > io_submit_sqe cannot return immediately because the reference count for > req is still held. Ensure that we free it. > > -- > Jens Axboe > >
