On Wed, Jul 03, 2019 at 03:34:55PM +0200, Johannes Thumshirn wrote: > On Wed, Jul 03, 2019 at 06:00:35AM -0700, Christoph Hellwig wrote: > [snip] > > phys_addr_t addr2 = page_to_phys(page) + offset + len - 1; > > > > if ((addr1 | mask) != (addr2 | mask)) > > return false; > > - > > if (bv->bv_len + len > queue_max_segment_size(q)) > > return false; > > - > > - return true; > > + return __bio_try_merge_page(bio, page, len, offset, same_page); > > } > > That's a lot of spurious whitespace changes here. Really just an empty line going away outside the directly touched code. I think it is more effective to boundle that here rather than having an extra patch for that..
