On 19-07-01 20:20:27, Chaitanya Kulkarni wrote: > Since discard requests are not as common as read and write requests > mark REQ_OP_DISCARD condition unlikely in the null_handle_rq() and > null_handle_bio(). > > Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx> Chaitanya, Just a simple doubt here. I just have tested this patch with 'dd' to see any performance benefit when queue_mode == 0 || 1. But I don't think it's worth it for the performance of read/write OR I have an wrong way to test it. you have never mentioned performance in this patch, though. But, I do like this patch because it will indicate what you have mentioned in the commit message in the code level. Reviewed-by: Minwoo Im <minwoo.im.dev@xxxxxxxxx> Thanks!
