Re: [PATCH] tools/io_uring: Use <asm/barrier.h> instead of tools/io_uring/barrier.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/1/19 9:41 AM, Bart Van Assche wrote:
> This patch avoids that multiple definitions of barrier primitives occur in
> the tools directory. This patch does not change the behavior of the code on
> x86 since on x86 smp_rmb() and smp_wmb() are defined as follows in
> tools/arch/x86/include/asm/barrier.h:
> 
>   #define barrier() __asm__ __volatile__("": : :"memory")
>   #define smp_rmb() barrier()
>   #define smp_wmb() barrier()

The kernel bits are just synced from liburing, essentially. So I don't
think it makes a lot of sense to add this change on the kernel side,
though cleaning up the liburing side would be great (and could then
bubble to the kernel as well).

-- 
Jens Axboe




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux