On 7/1/19 9:41 AM, Bart Van Assche wrote: > This patch avoids that multiple definitions of barrier primitives occur in > the tools directory. This patch does not change the behavior of the code on > x86 since on x86 smp_rmb() and smp_wmb() are defined as follows in > tools/arch/x86/include/asm/barrier.h: > > #define barrier() __asm__ __volatile__("": : :"memory") > #define smp_rmb() barrier() > #define smp_wmb() barrier() The kernel bits are just synced from liburing, essentially. So I don't think it makes a lot of sense to add this change on the kernel side, though cleaning up the liburing side would be great (and could then bubble to the kernel as well). -- Jens Axboe