I believe you have tested this patch with loop testcases present in the :- https://github.com/osandov/blktests/tree/master/tests/loop. With that, looks good. Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>. On 06/25/2019 10:55 AM, Florian Knauf wrote: > This patch removes the deprecated simple_strtol function from the option > parsing logic in the loopback device driver. Instead kstrtoint is used to > parse int max_loop, to ensure that input values it cannot represent are > ignored. > > Signed-off-by: Florian Knauf <florian.knauf@xxxxxxxxxxxxxxxxxxxx> > Signed-off-by: Christian Ewert <christian.ewert@xxxxxxxxxxxxxxxxxxxx> > --- > Thank you for your feedback. > > There's no specific reason to use kstrtol, other than the fact that we > weren't yet aware that kstrtoint exists. (We're new at this, I'm afraid.) > > We've amended the patch to make use of kstrtoint, which is of course much > more straightforward. > > drivers/block/loop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/loop.c b/drivers/block/loop.c > index 102d79575895..adfaf4ad37d1 100644 > --- a/drivers/block/loop.c > +++ b/drivers/block/loop.c > @@ -2289,7 +2289,7 @@ module_exit(loop_exit); > #ifndef MODULE > static int __init max_loop_setup(char *str) > { > - max_loop = simple_strtol(str, NULL, 0); > + kstrtoint(str, 0, &max_loop); > return 1; > } > >
