On 6/18/19 8:28 AM, Bart Van Assche wrote: > On 6/17/19 10:42 PM, Chaitanya Kulkarni wrote: >> + if (strcmp(op_str, "UNKNOWN") == 0) >> seq_printf(m, "%d", op); >> + else >> + seq_printf(m, "%s", op_str); > > My opinion about using strcmp() to check whether or not > req_opf-to-string conversion succeeded is that this is ugly ... > I didn't like that either, but I also don't want callers to repeat the string "UNKNOWN" or any other error string and return NULL from the blk_top_str(). Do you have any suggestion or preference ? > Bart. >
