Bart, > If this patch gets applied there will be three copies in the upstream > code that convert a REQ_OP_* constant into a string: one in > blk-core.c, one in blk-mq-debugfs.c and one in > include/trace/events/f2fs.h. Is it possible to avoid that duplication > and have only one function that does the number-to-string conversion? People often have a hard time correlating SCSI and block error messages with tracing output. So in general I'd like to see us not just trying to standardize the helper functions, but the actual output. I.e. I think it would be great to print exactly the same string for both error log messages and tracepoints. Since Chaitanya is doing a lot of work in this area anyway, that may be worth looking into? -- Martin K. Petersen Oracle Linux Engineering
