Hi Christoph, On Tue, Jun 11, 2019 at 05:10:02PM +0200, Christoph Hellwig wrote: > Hi Jens, hi Ming, > > this is the tested and split version of what I think is the better > fix for the get_user_pages page leak, as it leaves the intelligence > in the callers instead of in bio_try_to_merge_page. I am fine with either one from upstream developer view, so let Jens decide. However: We have to backport the fixes to -stable tree, and downstream need to ship the fix too. The issue is quite serious because the leak is in IO path and the whole system ram can be used up easily on some workloads. So I think the fix should be for 5.2, however, regression risk might be increased by pulling cleanup & re-factor in now. I really appreciate you may cook a fix-only patch for this issue. Especially the change in add pc page code isn't necessary for fixing the issue. Thanks, Ming
