On Mon, May 06, 2019 at 03:30:27PM +0200, Christoph Hellwig wrote: > On Mon, May 06, 2019 at 04:19:54PM +0800, Ming Lei wrote: > > I remember that this way is the initial version of Jens' patch, however > > kernel bug is triggered: > > > > https://lore.kernel.org/linux-block/20190226034613.GA676@sol.localdomain/ > > > > Or maybe I miss some recent changes, could you explain it a bit? > > I'm not even sure how the original would crash.. When I run the > rest locally it gets and EBUSY from ioctl LOOP_SET_FD, so I'm > not sure what it tends up testing in the end. I also did another run with KASAN enabled and a clean environment, this gives no EBUSY and still works fine. I still don't understand what the original problem might have been here, though.