On 05/06/2019 09:38 AM, Minwoo Im wrote: > On 5/7/19 1:25 AM, Chaitanya Kulkarni wrote: >> We need to get rid of the string comparison here. > Chaitanya, > > Do you mean that test case bash script should check the result of output > and return some error value instead of zero instead of *.out comparison ? > > Thanks, > We need to get rid the string comparison as much as we can e.g. in following output the nvme-cli output should not be compared but the return value itself. -Discovery Log Number of Records 1, Generation counter 1 +Discovery Log Number of Records 1, Generation counter 2 =====Discovery Log Entry 0====== trtype: loop adrfam: pci subtype: nvme subsystem -treq: not specified +treq: not specified, sq flow control disable supported portid: X trsvcid: subnqn: blktests-subsystem-1 Reason :- we cannot rely on the output as it tends to change with development which triggers fixes in blktests, unless testcase is focused on entirely on examining the output of the tool.
