Re: [PATCH 14/15] nvme-pci: optimize mapping single segment requests using SGLs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Klaus Birkelund <klaus@xxxxxxxxxxxx>, Jens Axboe <axboe@xxxxxx>, Keith Busch <keith.busch@xxxxxxxxx>, Sagi Grimberg <sagi@xxxxxxxxxxx>, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx
Subject: Re: [PATCH 14/15] nvme-pci: optimize mapping single segment requests using SGLs
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 30 Apr 2019 16:32:22 +0200
In-reply-to: <20190430141722.GA19100@apples.localdomain>
References: <20190321231037.25104-1-hch@lst.de> <20190321231037.25104-15-hch@lst.de> <20190430141722.GA19100@apples.localdomain>
User-agent: Mutt/1.5.17 (2007-11-01)

On Tue, Apr 30, 2019 at 04:17:22PM +0200, Klaus Birkelund wrote:
> nvme_setup_sgl_simple does not set the PSDT field, so bypassing
> nvme_pci_setup_sgls causing controllers to assume PRP.
> 
> Adding `cmnd->flags = NVME_CMD_SGL_METABUF` in nvme_setup_sgl_simple
> fixes the issue.

Indeed.  Can you send the patch?

References:
- [RFC] optimize nvme single segment I/O
  - From: Christoph Hellwig
- [PATCH 14/15] nvme-pci: optimize mapping single segment requests using SGLs
  - From: Christoph Hellwig
- Re: [PATCH 14/15] nvme-pci: optimize mapping single segment requests using SGLs
  - From: Klaus Birkelund

Prev by Date: Re: [PATCH 14/15] nvme-pci: optimize mapping single segment requests using SGLs
Next by Date: Re: [PATCH] io_uring: avoid page allocation warnings
Previous by thread: Re: [PATCH 14/15] nvme-pci: optimize mapping single segment requests using SGLs
Next by thread: [PATCH 15/15] nvme-pci: tidy up nvme_map_data
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]