If Jens is okay with this change then :- Reviewed-by : Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>. On 4/28/19 12:48 AM, Minwoo Im wrote: > __data_len and __sector are internal fields which should not be accessed > directly in driver-level like the comment above it. But, tag field can > be accessed by driver level directly so that we need to make the comment > right by moving it to some other place. > > Signed-off-by: Minwoo Im <minwoo.im.dev@xxxxxxxxx> > --- > include/linux/blkdev.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 317ab30d2904..639ca948d644 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -137,11 +137,11 @@ struct request { > unsigned int cmd_flags; /* op and common flags */ > req_flags_t rq_flags; > > + int tag; > int internal_tag; > > /* the following two fields are internal, NEVER access directly */ > unsigned int __data_len; /* total data len */ > - int tag; > sector_t __sector; /* sector cursor */ > > struct bio *bio; >