On Sat, Apr 27, 2019 at 06:45:43AM +0800, Ming Lei wrote: > Still no difference between your suggestion and the way in this patch, given > driver specific change is a must. Even it is more clean to hold the > queue refocunt by drivers explicitly because we usually do the get/put pair > in one place, instead that getting refcnt in one subsystem, and doing put in > another place. > > I am going to drop this patch in V8 since my original plan is to fix block > layer's race in this patchset. Doing the untegistration and final reference drop is just a bad pattern, leading to possible bugs. I'm fine with you just dropping it for now, I guess I'll just send a scripted conversion moving the put to the drivers to Jens after -rc1 to sort it out. Probably including a rename of blk_cleanup_queue so that everyone notices the difference.
