On Fri, Apr 26, 2019 at 06:45:20PM +0800, Ming Lei wrote: > Commit 399254aaf489211 ("block: add BIO_NO_PAGE_REF flag") introduces > BIO_NO_PAGE_REF, and once this flag is set for one bio, all pages > in the bio won't be get/put during IO. > > However, if one bio is submitted via __blkdev_direct_IO_simple(), > even though BIO_NO_PAGE_REF is set, pages still may be put. > > Fixes this issue by avoiding to put pages if BIO_NO_PAGE_REF is > set. > > Fixes: 399254aaf489211 ("block: add BIO_NO_PAGE_REF flag") > Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx>