On 4/24/19 7:20 PM, Sagi Grimberg wrote:
per-queue bioset is used originally for avoiding deadlock, are you
sure the static bioset is safe?
Can you explain this? I didn't find any indication of that in the change
log history...
Originally introduced by Kent:
--
commit 54efd50bfd873e2dbf784e0b21a8027ba4299a3e
Author: Kent Overstreet <kent.overstreet@xxxxxxxxx>
Date: Thu Apr 23 22:37:18 2015 -0700
Phew. I was wondering whether I'd been too stupid to find it.
And having looked at it a bit closer, moving the bioset into the holding
structure would induce more churn, as we'd need to pass the bioset into
blk_queue_split(), which would mean to update all drivers (11 in total)
for no real gain IMO; bio splitting shouldn't really be a regular
occurrence and hence the bioset should only be used infrequently.
However, I really would like to get feedback to the actual patch, as
this solves a real customer issues we've had (or still have, depending
on the view :-)
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@xxxxxxx +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
