On Tue, Apr 16, 2019 at 11:03:00AM -0600, Jens Axboe wrote: > On 4/16/19 10:46 AM, Christoph Hellwig wrote: > > s/overflowed/overflow/ in the subject. > > > > Otherwise this looks good to me: > > > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > > > Although this will create yet another conflict between Linus' tree > > and the 5.2 block tree. > > > > Although maybe Jens still reset the tree and move the merge past this.. > > That was my main worry too... But I'll probably just deal with it and > redo the merge, I don't want to do two, and I don't want to have to > deal with answering for why we get repeated conflicts in this area. This one is a fix which should affect on loop and nvme-loop only in theory. That is typical conflict between fix and feature(improvement). Anyway, sorry for the a bit late fix. > > For the patch, I do generally prefer doing an AND with PAGE_MASK > rather than a modulo with PAGE_SIZE. I know the compiler will take > care of it, but still, it's more prudent imho. OK, do it in V2. Thanks, Ming
