On 4/11/19 8:09 PM, Jason Yan wrote: > If the last bio returned is not dio->bio, the status of the bio will > not assigned to dio->bio if it is error. This will cause the whole IO > status wrong. > > ksoftirqd/21-117 [021] ..s. 4017.966090: 8,0 C N 4883648 [0] > <idle>-0 [018] ..s. 4017.970888: 8,0 C WS 4924800 + 1024 [0] > <idle>-0 [018] ..s. 4017.970909: 8,0 D WS 4935424 + 1024 [<idle>] > <idle>-0 [018] ..s. 4017.970924: 8,0 D WS 4936448 + 321 [<idle>] > ksoftirqd/21-117 [021] ..s. 4017.995033: 8,0 C R 4883648 + 336 [65475] > ksoftirqd/21-117 [021] d.s. 4018.001988: myprobe1: (blkdev_bio_end_io+0x0/0x168) bi_status=7 > ksoftirqd/21-117 [021] d.s. 4018.001992: myprobe: (aio_complete_rw+0x0/0x148) x0=0xffff802f2595ad80 res=0x12a000 res2=0x0 > > We always have to assign bio->bi_status to dio->bio.bi_status because we > will only check dio->bio.bi_status when we return the whole IO to > the upper layer. Looks good, thanks. Applide for 5.1, marked stable. -- Jens Axboe