On Tue, Apr 09, 2019 at 11:48:39AM +0200, Christoph Hellwig wrote: > On Mon, Apr 08, 2019 at 07:12:04AM -0700, Matthew Wilcox wrote: > > On Mon, Apr 08, 2019 at 08:07:55AM +0200, Hannes Reinecke wrote: > > > Oh yes, please do. > > > The macros are fast becoming unparseable :-) > > > > I think something that would help is removing the mandatory 'i' parameter > > to this iterator. Most of the users don't use it, and the ones that do > > can implement it themselves. eg: > > Yeah, I quickly hacked this up during a meeting yesterday and we have > exactly two users of the iterator. Patch against the for-linus tree > below, although it conflicts with some of the 5.2 work. Maybe it is > best to merge this just after the next rc1.. > > -- > From 6a872f0186846a64a898b149be54d385f9f03f8b Mon Sep 17 00:00:00 2001 > From: Christoph Hellwig <hch@xxxxxx> > Date: Mon, 8 Apr 2019 18:11:44 +0200 > Subject: block: remove the i argument to bio_for_each_segment_all > > We only have two callers that need the simple loop iterator, and > they can easily do it themselves. > > Suggested-by: Matthew Wilcox <willy@xxxxxxxxxxxxx> > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Nice cleanup! Looks good, Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx> -- Johannes Thumshirn SUSE Labs Filesystems jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
