On Mon, 2019-04-08 at 12:46 +-0200, Christoph Hellwig wrote: +AD4 No caller uses bio+AF8-iov+AF8-iter+AF8-get+AF8-pages multiple times on a given bio, +AD4 and that funtionality isn't all that useful. Removing it will make +AD4 some future changes a little easier and also simplifies the function +AD4 a bit. +AD4 +AD4 Signed-off-by: Christoph Hellwig +ADw-hch+AEA-lst.de+AD4 +AD4 --- +AD4 block/bio.c +AHw 15 +-+-+-+-+-+---------- +AD4 1 file changed, 6 insertions(+-), 9 deletions(-) +AD4 +AD4 diff --git a/block/bio.c b/block/bio.c +AD4 index ad346082a971..2fa624db21c7 100644 +AD4 --- a/block/bio.c +AD4 +-+-+- b/block/bio.c +AD4 +AEAAQA -958,7 +-958,10 +AEAAQA static int +AF8AXw-bio+AF8-iov+AF8-iter+AF8-get+AF8-pages(struct bio +ACo-bio, struct iov+AF8-iter +ACo-iter) +AD4 int bio+AF8-iov+AF8-iter+AF8-get+AF8-pages(struct bio +ACo-bio, struct iov+AF8-iter +ACo-iter) +AD4 +AHs +AD4 const bool is+AF8-bvec +AD0 iov+AF8-iter+AF8-is+AF8-bvec(iter)+ADs +AD4 - unsigned short orig+AF8-vcnt +AD0 bio-+AD4-bi+AF8-vcnt+ADs +AD4 +- int ret +AD0 -EFAULT+ADs Is the value -EFAULT used anywhere? In other words, can +ACI +AD0 -EFAULT+ACI be left out? Otherwise this patch looks good to me. Thanks, Bart.
