On 4/1/19 8:26 PM, Ming Lei wrote: > Commit f6970f83ef79 ("block: don't check if adjacent bvecs in one bio can > be mergeable") changes bvec merge by only considering two bvecs from > different bios. However, if the former bio doesn't inlcude any io bvec, > then the following warning may be triggered: > > warning: ‘bvec.bv_offset’ may be used uninitialized in this function [-Wmaybe-uninitialized] > > In practice, it shouldn't be triggered. > > Fixes it by adding check on former bio, the check shouldn't add any cost > given 'bio->bi_iter' can be hit in cache. Applied, thanks. -- Jens Axboe