Re: [PATCH] block: Revert v5.0 blk_mq_request_issue_directly() changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/5/19 8:00 AM, Bart Van Assche wrote:
> On 4/4/19 11:06 PM, Christoph Hellwig wrote:
>> On Thu, Apr 04, 2019 at 10:08:43AM -0700, Bart Van Assche wrote:
>>> blk_mq_try_issue_directly() can return BLK_STS*_RESOURCE for requests that
>>> have been queued. If that happens when blk_mq_try_issue_directly() is called
>>> by the dm-mpath driver then dm-mpath will try to resubmit a request that is
>>> already queued and a kernel crash follows. Since it is nontrivial to fix
>>> blk_mq_request_issue_directly(), revert the blk_mq_request_issue_directly()
>>> changes that went into kernel v5.0.
>>
>> And what are we going to do about 5.1+?
> 
> Hi Christoph,
> 
> This patch was developed and tested on my setup against Jens' for-next 
> branch. So this patch should apply fine on kernel v5.1-rc3.

I'm inclined to apply the bundled up version. It applies with a bit of
help and merges cleanly between the 5.1 and 5.2 branches.

-- 
Jens Axboe




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux