Re: [PATCH 1/1] blk-mq: do not reset plug->rq_count before the list is sorted

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dongli Zhang <dongli.zhang@xxxxxxxxxx>
Subject: Re: [PATCH 1/1] blk-mq: do not reset plug->rq_count before the list is sorted
From: Jens Axboe <axboe@xxxxxxxxx>
Date: Thu, 4 Apr 2019 08:37:52 -0600
Cc: linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <1554346664-24038-1-git-send-email-dongli.zhang@oracle.com>
References: <1554346664-24038-1-git-send-email-dongli.zhang@oracle.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

On 4/3/19 8:57 PM, Dongli Zhang wrote:
> We would never be able to sort the list if we first reset plug->rq_count
> which is used in conditional check later.

Well, that was pretty stupid. Thanks for the patch, applied.

-- 
Jens Axboe

References:
- [PATCH 1/1] blk-mq: do not reset plug->rq_count before the list is sorted
  - From: Dongli Zhang

Prev by Date: Re: [PATCH 1/2] cpumask: Introduce possible_cpu_safe()
Next by Date: Re: [PATCH] block: Fix blk_mq_try_issue_directly()
Previous by thread: Re: [PATCH 1/1] blk-mq: do not reset plug->rq_count before the list is sorted
Next by thread: [PATCH V4 0/7] blk-mq: fix races related with freeing queue
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]

Powered by Linux