Re: [PATCH] block: use blk_free_flush_queue() to free hctx->fq in blk_mq_init_hctx

[Ming Lei <tom.leiming@xxxxxxxxx>]

On Mon, Apr 1, 2019 at 9:41 PM Shenghui Wang <shhuiw@xxxxxxxxxxx> wrote:
>
> kfree() can leak the hctx->fq->flush_rq field.
>
> Signed-off-by: Shenghui Wang <shhuiw@xxxxxxxxxxx>
> ---
>  block/blk-mq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 3ff3d7b49969..f3b0d33bdf88 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -2332,7 +2332,7 @@ static int blk_mq_init_hctx(struct request_queue *q,
>         return 0;
>
>   free_fq:
> -       kfree(hctx->fq);
> +       blk_free_flush_queue(hctx->fq);
>   exit_hctx:
>         if (set->ops->exit_hctx)
>                 set->ops->exit_hctx(hctx, hctx_idx);

Reviewed-by: Ming Lei <ming.lei@xxxxxxxxxx>

Thanks,
Ming Lei