Re: [PATCH 13/16] block: sed-opal: use named Opal tokens instead of integer literals

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: David Kozub <zub@xxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 13/16] block: sed-opal: use named Opal tokens instead of integer literals
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 28 Mar 2019 10:06:30 -0700
Cc: Jens Axboe <axboe@xxxxxxxxx>, Jonathan Derrick <jonathan.derrick@xxxxxxxxx>, Scott Bauer <sbauer@xxxxxxxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Jonas Rabenstein <jonas.rabenstein@xxxxxxxxxxxxxxxxxxxxxxx>
In-reply-to: <1550103368-4605-14-git-send-email-zub@linux.fjfi.cvut.cz>
References: <1550103368-4605-1-git-send-email-zub@linux.fjfi.cvut.cz> <1550103368-4605-14-git-send-email-zub@linux.fjfi.cvut.cz>
User-agent: Mutt/1.9.2 (2017-12-15)

On Thu, Feb 14, 2019 at 01:16:05AM +0100, David Kozub wrote:
> Replace integer literals by Opal tokens defined in opal_proto.h where
> possible.
> 
> Signed-off-by: David Kozub <zub@xxxxxxxxxxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH 00/16] sed-opal: fix shadow MBR enable/disable and clean up code
  - From: David Kozub
- [PATCH 13/16] block: sed-opal: use named Opal tokens instead of integer literals
  - From: David Kozub

Prev by Date: Re: [PATCH 11/16] block: sed-opal: add token for OPAL_LIFECYCLE
Next by Date: Re: [PATCH 14/16] block: sed-opal: pass steps via argument rather than via opal_dev
Previous by thread: Re: [PATCH 13/16] block: sed-opal: use named Opal tokens instead of integer literals
Next by thread: Re: [PATCH 13/16] block: sed-opal: use named Opal tokens instead of integer literals
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]