On Mon, 2019-03-25 at 10:22 -0600, Jens Axboe wrote: +AD4 We now wrap sbitmap waitqueues in an active counter, so we can avoid +AD4 iterating wakeups unless we have waiters there. This works as long as +AD4 everyone that's manipulating the waitqueues use the proper helpers. For +AD4 the tag wait case for shared tags, however, we add ourselves to the +AD4 waitqueue without incrementing/decrementing the -+AD4-ws+AF8-active count. This +AD4 means that wakeups can take a long time to happen. +AD4 +AD4 Fix this by manually doing the inc/dec as needed for the wait queue +AD4 handling. +AD4 +AD4 Fixes: 5d2ee7122c73 (+ACI-sbitmap: optimize wakeup check+ACI) +AD4 Signed-off-by: Jens Axboe +ADw-axboe+AEA-kernel.dk+AD4 Hi Jens, Since commit 5d2ee7122c73 went upstream in kernel v5.0, does this patch need a +ACI-Cc: stable+ACI tag? Thanks, Bart.
