On 3/15/19 12:30 AM, Dominique Martinet wrote: > Jens, Steven, > > Jens Axboe wrote on Thu, Mar 14, 2019: >> On 3/14/19 7:37 PM, Steven Rostedt wrote: >>> I noticed this old patch in my inbox. It looks like a legit cleanup. >>> Want to take it? >> >> Indeed, I've applied it. Thanks! > > Thanks. I am terribly sorry about this patch series to be honest, I did > not prepare it properly and sent too many generic patches at once but > more importantly some were unsafe (strlcpy expects the input string to > be validly formatted, because it basically does strlen() on it to check > how much hasn't been copied for its return value) > I was pointed out strscpy instead as a safer alternative. > > In this case `name` comes from bdevname() which is disk_name() in > block/partition-generic.c which is a snprintf, so we are guaranted > null truncation from there and it should be OK, but I wanted to check > and point it out. Dropped. -- Jens Axboe
