On 3/11/19 10:44 AM, Keith Busch wrote: > On Fri, Mar 08, 2019 at 09:31:02PM -0700, Jens Axboe wrote: >> On 3/8/19 2:59 PM, Keith Busch wrote: >>> Make depth options command line parameters so a recompile isn't >>> required to see how it affects performance. >> >> Thanks, everything really should be command line options. But I never >> bothered, it wasn't mean to live this long :-) > > It's a nice convenient way to do some quick and light benchmarking, > so we've been finding it very useful. Yeah it is, which is also why I've been using it quite a bit. Quick and easy. > But I totally rushed this patch and just sent it once I heard it "worked", > and it really doesn't because malloc doesn't zero the buffer. My mistake, > kzalloc spoiled me. Here's the fix: Applied, thanks. -- Jens Axboe
