Re: [PATCH 4/6] block: put the same page when adding it to bio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +int __bio_add_pc_page(struct request_queue *q, struct bio *bio, struct page
> +		      *page, unsigned int len, unsigned int offset,
> +		      bool put_same_page)

Very odd indentation, we try to never have a linebreak between the type
and its parameter name.

> +static inline int bio_add_pc_page(struct request_queue *q, struct bio *bio, struct page
> +		    *page, unsigned int len, unsigned int offset)
> +{
> +	return __bio_add_pc_page(q, bio, page, len, offset, false);
> +}

Too long line.  Also please keep bio_add_pc_page in bio.c and export
it instead of the low-level helper.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux